BCC support #369
Merged
BCC support #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the feedback @delbertooo I tested this function locally and found no problem. we will release it together in v2.0.2 version However, there are currently some problems with the interface style. I don't think it is a big problem. We can improve it in the next version. |
This was referenced Mar 23, 2022
I didn't commit a rebuilt I guess I wasn't sure if that is the right way, as I'm not the biggest fan of binaries / artifacts in the repository. |
delbertooo
added a commit
to delbertooo/maildev
that referenced
this pull request
Mar 31, 2022
djfarrelly
pushed a commit
that referenced
this pull request
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As maildev is primarily a debugging tool we want to validate the correctness of TO, CC and BCC as well.
See #233
Possible solutions
Duplicating emails won't help debugging and may make it even worse. So we went for the "show in preview" option.
Implementation
Bcc should not be contained in the mail source. Otherwise it wouldn't be a "blind" copy as the recipients could see the blind copy recipients. Every recipient (to, cc, bcc) should be part of the
RCPTthough. So from my understanding and the insight of this Mailtrap article bcc should beallRecipients - to - cc. This calculated bcc is what I implemented and added to the stored parsed email.On the GUI side I found that it's actually hard to validate the recipients in maildev. Besides the headers this information isn't really shown in detail. To fix the missing details I implemented a panel below the email toolbar to show information. I'm not quite sure if this panel meets your UI expectations but in my opinion something like that would be a great addition to the project. This way the user can easily debug who should've received the mail.
Preview
I built a docker image as a preview with the recipients/bcc support added by this pull requests. You can find it at delbertooo/maildev-bcc.