Skip to content

Handle SMTPConnection errors. Fixes #287. #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

Handle SMTPConnection errors. Fixes #287. #293

merged 2 commits into from
Mar 30, 2020

Conversation

djfarrelly
Copy link
Member

Purpose

Handle SMTPConnection errors gracefully. Fixes #287.

Notes

If an EventEmitter does not have at least one listener registered for the 'error' event, and an 'error' event is emitted, the error is thrown, a stack trace is printed, and the Node.js process exits. (source - Node.js official docs)

@djfarrelly
Fix optional argument for auto-relay
7963620
@djfarrelly
Handle SMTPConnection errors. Fixes #287.
a06188e 
Node.js' event emitter will throw an error and exit the program
if the error event is not handled.
@djfarrelly djfarrelly added the bug label Mar 30, 2020
@djfarrelly djfarrelly merged commit 92da777 into master Mar 30, 2020
@djfarrelly djfarrelly deleted the fix/handle-smtp-connection-errors branch March 30, 2020 14:07
@djfarrelly djfarrelly added this to the 2.0.0 milestone Mar 30, 2020
@djfarrelly djfarrelly mentioned this pull request Mar 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.x
Development

Successfully merging this pull request may close these issues.

unhandled 'error' event crashes maildev shortly after viewing email in gui
1 participant
@djfarrelly