Add an option to disable web interface #165
Conversation
Useful when using MailDev as part of a unit test, otherwise web server prevents test runner from quitting the process
|
Fixes #75 |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 60.4% 60.24% -0.17%
==========================================
Files 7 7
Lines 490 493 +3
Branches 106 108 +2
==========================================
+ Hits 296 297 +1
- Misses 194 196 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hey @sponte, thanks for this change. I'm all for it with the small change that I mentioned in my comment. Let me know if you want to tackle that or I should!
| web.close | ||
| ], function(err, results) { | ||
| var tasks = [mailserver.end]; | ||
| if(web) { |
There was a problem hiding this comment.
I think this will always be truthy as it's the module's export object. It could be useful to have a method like web.isListening()?
Now that I think of it, the createServer call in web.js should likely be moved into the start function then the isListening() function can check if server is defined or not. If you'd like to make this change, that works with me or I can hack it together after this is merged. Let me know what you think!
|
@djfarrelly sorry for not replying, got lost in my inbox. Thanks for making adjustments and accepting pull request. All the best |
No description provided.