Fix bug when switching both Lua and LuaRocks versions #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use.go
Outdated
| @@ -20,6 +20,7 @@ func UseInstalledVersion(cfg *TargetConfig, ver string) { | |||
| if err := os.Chdir(wd); err != nil { | |||
| fatalf("failed to chdir: %v", err) | |||
| } | |||
| defer os.Chdir(CWD) | |||
There was a problem hiding this comment.
The deferred 'os.Chdir(CWD)' combined with an explicit call to 'os.Chdir(CWD)' later creates potential redundancy in restoring the working directory. Consider consolidating the restoration logic so that error checking remains consistent and the directory is changed only when necessary.
Suggested change
| defer os.Chdir(CWD) | |
| // Removed the deferred os.Chdir(CWD) to avoid redundancy. |
Copilot uses AI. Check for mistakes.
The issue occurred when switching LuaRocks version after Lua version, resulting in "not installed" errors even when the version existed. This happened because the working directory changed during Lua version switching, causing incorrect path resolution for LuaRocks.
1fa5064 to
e1628c0
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
use.go:47
- [nitpick] Consider declaring a constant for "luarocks" to improve clarity and ease future updates.
else if cfg.Name != "luarocks" {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurred when switching LuaRocks version after Lua version, resulting in "not installed" errors even when the version existed. This happened because the working directory changed during Lua version switching, causing incorrect path resolution for LuaRocks.