Skip to content

Auto redirect if the new URL just adds a trailing slash #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2021
Merged

Auto redirect if the new URL just adds a trailing slash #271

merged 2 commits into from
Dec 3, 2021

Conversation

awfulcooking
Copy link
Contributor

These redirects are probably necessary, not going anywhere & harmless, let's not prompt for them

e.g. gemini://some-place/~user => gemini://some-place/~user/

@makew0rld
Copy link
Owner

The only potential problem I see is that someone could keep redirecting from gemini://some-place/~user/ to gemini://some-place/~user//, etc. But redirects are capped at 5 anyway so it should be fine.

@makew0rld makew0rld merged commit 92fd9ed into makew0rld:master Dec 3, 2021
@makew0rld
Copy link
Owner

Thanks!

makew0rld added a commit that referenced this pull request Dec 3, 2021
@makew0rld
Doc for #271
a033731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awfulcooking @makew0rld