Allow opening local files by relative path #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local files can now be loaded by relative path, rather than the whole path preceded by the `file://` scheme indicator. It first checks whether or not the requested URL has a scheme (by checking for `://` in the URL). If not, it checks to see if the file exists before opening. It also allows making intention known by specifying `./` or `../` before the URL, closely matching the behavior of Firefox. This borrows code from @singalhimanshu's PR (makew0rld#232). Resolves makew0rld#231
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local files can now be loaded by relative path, rather than the
whole path preceded by the
file://scheme indicator. It firstchecks whether or not the requested URL has a scheme (by checking
for
://in the URL). If not, it checks to see if the file existsbefore opening. It also allows making intention known by
specifying
./or../before the URL, closely matching thebehavior of Firefox.
This borrows code from @singalhimanshu's PR (#232).
Resolves #231