Hi @makeworld-the-better-one. I'm happy to test these changes - let me know once it is merged and I'll try it out

@LukeEmmet Thanks! There's currently many bugs going on, so maybe I'll @ you again right before merge and you can test out the issue in #43. You're also welcome to test on your own time, there just might be other bugs. Let me know and I can upload a binary. Here's a current one, no guarantees. (Windows 64-bit)

amfora.exe.zip

hi @makeworld-the-better-one I just tried that binary - it works! Well I only tested the pasting long URL into the address box though. I'm happy to try future updates, let me know. I'm not sure if I'm confident enough to create a build based on an unmerged PR, so you might have to create a binary for me again though

(edit) I did spot a minor thing - when it navigates to a web URL, it leaves the info box open, which I cannot seem to close by pressing return, space or escape. It just reactivates the [ok] button and launches the web URL again.

That's good enough for me! Very happy to hear that works. I might @ you later for future updates, but I don't see this regressing (since it's not my code) so I think we're good. Thanks!

I'm not sure if anyone is watching this thread, but if they are, I'd appreciate if they could try out this PR and just do some general testing, find out if anything is broken or buggy or doesn't work like the master branch does. Thanks!

git clone https://github.com/makeworld-the-better-one/amfora
git checkout cview-update
make
./amfora

@objectliteral @sudobash1 @ThomasAdam If any of you are interested in trying out this branch and seeing if anything is broken that would be much appreciated. It's pretty much ready at this point, the step I'm on now is just "Extensive general testing". So just try out all the features you know, use it normally, do weird things, etc. If the bug you find still happens on the master branch, you can make an issue, but otherwise just report it in this thread.

Thank you!

Hey @makeworld-the-better-one

Sure! So far, so good. I take it that the tab bar along the top is now supposed to wrap if the number of tabs is greater than the terminal width? The version on master doesn't wrap the tab bar past the terminal width.

@ThomasAdam Interesting, I didn't expect that. The bar is done differently now. I'll see what I can do, as I think wrapping is worse off.

I noticed a difference in horizontal scrolling with the new version: When a line is long enough (or the terminal narrow enough) such that the document can be scrolled horizontally, the version in master scrolls into the left padding, whereas the cview-update version preserves the padding and cuts off the text.

Can be easily reproduced with preformatted text:

echo -e "```\nA really long line of text that is preformatted to it won't wrap and will cause you to be able to do horizontal scrolling... Maybe need some Lorem Ipsum in here, but I'm too lazy to generate some. Oh and I hope you don't test on a ultra-wide monitor...\n```\nHere is normal text" > wrap.gmi

I don't know which of the two scrolling behaviors is prefered. (I think I like the old one better...)

@objectliteral Thanks for reminding me about this. See 90654cd and #26 for why this happened. Basically the old left margin was just spaces that was stored as part of the page rendering. Now it's done as a flex element, which is much much more efficient.

However I think this is out of scope for this PR. I can make a new issue for this when this gets merged.

@ThomasAdam I filed this issue with cview about the tab bar wrapping. It will not be fixed before this PR is merged.