Skip to content

Conversation

tslocum
Copy link
Contributor

@tslocum tslocum commented Oct 26, 2020

Favicon support must be re-implemented.

@makew0rld
Copy link
Owner

Wow, having the upstream maintainer come and update your project for you is really phenomenal. Thank you, this is very much appreciated. This was going to be a lot of tedious text work for me, and it's great to have it complete. I also appreciate the simplification of the help page code, it seems obvious now that text/tabwriter should have been used.

To re-add favicon support as you mentioned, this is correct function, right?

func (t *TabbedPanels) SetTabLabel(name, label string)

So that the label of the tab is changed to the emoji.

@makew0rld makew0rld changed the base branch from master to cview-update October 29, 2020 18:42
@makew0rld
Copy link
Owner

I have changed the base branch to cview-update, which is where I had started updating cview previously. I will re-implement favicons there and do lots of testing before merging to master. If you realize you missed something or weren't finished with this PR, feel free to add a comment in #107 or make another PR. Thanks again!

@makew0rld
Copy link
Owner

Also, one thing I think you missed is adding .Truecolor() when loading custom colors from the config. Because those colors could be any RGB colors, not just from the xterm 256. I will add that in #107, let me know if I'm misunderstanding.

@makew0rld makew0rld merged commit 3ef059a into makew0rld:cview-update Oct 29, 2020
@tslocum
Copy link
Contributor Author

tslocum commented Oct 29, 2020

Yes, that is the correct function to use, and I did miss updating to use TrueColor values. Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants