sync_blocks has been made a member of the test framework in bitcoin#15773, but the global helper has been left intact for now.

It has been suggested to move the implementation to the member function as well bitcoin#15773 (review)

Implementing the functionality in a single place in the test framework allows the method to take account of contextual information, such as global timeout modifications. Also, having a global that does almost-but-not-quite the same thing is confusing for test writers and reviewers.

So the implementation should be moved, along with removing the global helper.

Useful skills:

Python3, basic understanding of the test framework

Want to work on this issue?

The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.