Improve mackerel-agent configtest: detect unexpected key
#813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lufia
reviewed
Sep 14, 2022
config/validate.go
Outdated
| return nil, fmt.Errorf("failed to test config: %s", err) | ||
| } | ||
|
|
||
| var unexpectedKey []string = make([]string, 0) |
There was a problem hiding this comment.
[may] This might be declared just var unexpectedKey []string simply.
more better name: unexpectedKeys
| } | ||
|
|
||
| for k1, v := range config.Plugin { | ||
| /* |
commands.go
Outdated
|
|
||
| do configtest | ||
| */ | ||
| func doConfigtest(fs *flag.FlagSet, argv []string) error { | ||
| conf, err := resolveConfig(fs, argv) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to test config: %s", err) | ||
| return fmt.Errorf("\x1b[31m[CRITICAL] failed to test config: %s \x1b[0m", err) |
There was a problem hiding this comment.
mackerel-agent runs on Windows, so we had better either to use https://github.com/mattn/go-colorable or https://github.com/fatih/color, or to disable ANSI escape codes except on go:build unix.
This was referenced Nov 2, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #810
example of WARNING
~/desktop/mackerel-agent $ ./build/mackerel-agent configtest -conf=/usr/local/etc/mackerel-agent-sample.conf [WARNING] podfile is unexpected key [WARNING] foobar is unexpected key [WARNING] foobar.command is unexpected key [WARNING] foobar.env.FOO is unexpected key [WARNING] foobar.env is unexpected key [WARNING] plugins.check.first is unexpected key [WARNING] plugins.check.first.command is unexpected key [WARNING] plugin.metric.first is unexpected key [WARNING] plugin.check.first is unexpected key [WARNING] plugin.check.second is unexpected key [WARNING] plugin.foo.bar is unexpected keyexample of CRITICAL