Skip to content

Fix the path is encoded twice #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix the path is encoded twice #176

merged 1 commit into from
Jun 10, 2025

Conversation

yohfee
Copy link
Contributor

@yohfee yohfee commented Jun 10, 2025 •
edited
Loading

url.URL.String() encodes its Path. So if requestInternal arg path is already encoded, it will be encoded twice.

And http.Request.URL.Path is decoded value but http.Request.URL.RawPath is encoded value.
They should be treated individually.

Furthermore RawPath may be empty when Path has no encodable characters.
https://cs.opensource.google/go/go/+/refs/tags/go1.24.4:src/net/url/url.go;l=366-383

yseto
yseto approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@yseto yseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.

@yohfee yohfee merged commit 24ca054 into master Jun 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yseto yseto yseto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yohfee @yseto