Possible fix for #41 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible fix for #41
bartreardon
reviewed
Nov 17, 2023
| @@ -309,7 +309,7 @@ struct Outset: ParsableCommand { | |||
| ensureRoot("add scripts to override list") | |||
|
|
|||
| for var override in addOverride { | |||
| if !override.contains(loginOnceDir) { | |||
| if !override.contains(loginOnceDir) && !override.contains(loginOncePrivilegedDir) { | |||
There was a problem hiding this comment.
that should work - the idea here is you can pass just the script name and with no full path it will make an assumption about it being a login-once.
Might me better to make it less reliant on a specific path (e.g. if another once folder is added in the future then this will need to change again)
maybe check to see if the passed in override has a path component and if not, then assume login-once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will fix the logic that causes the problem in Issue 41.
The check now looks for both a missing LoginOnceDir and loginOncePrivilegedDir before inserting the LoginOnceDir.