Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: macournoyer/thin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.1
Choose a base ref
...
head repository: macournoyer/thin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.2
Choose a head ref
  • 4 commits
  • 11 files changed
  • 4 contributors

Commits on Dec 25, 2021

  1. Increase timeout when checking for server stop

    On Ubuntu Impish (development version), we're currently facing a
    problem where thin's testsuite fails when it runs on an armhf system.
    After some investigation, I noticed that the reason for this failure
    was that the server was still running even after the loop on
    spec/spec_helper.rb:stop_server.
    
    Given that the loop is actively checking to see if the server has
    stopped, I'd like to propose that the timeout be increased from 1
    second to 10 seconds.  Although I'm not a fan of the
    "let's-just-increase-the-timeout" type of solutions, in this
    particular case I think it's justified and makes sense (1 second may
    indeed be too quick for the server to properly stop).
    
    Signed-off-by: Sergio Durigan Junior <sergio.durigan@canonical.com>
    Sergio Durigan Junior authored and ioquatix committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    10607a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Update tcp_spec.rb (#382)

    Fix a typo
    murraybd authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2d75699 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Update code base for Ruby v3.2 (#392)

    * `File.exists?` is removed in ruby 3.2
    
    * Fix deprecated rspec expectation syntax
    
    * Fix `Socket.gethostbyname` deprecation
    
    * Test on ruby 3.2 and rack 2.
    Vasfed authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    829c3aa View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Bump patch version.

    ioquatix committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    85b956c View commit details
    Browse the repository at this point in the history
Loading