-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix #11325, #11363, refactor score movement handling code, and fix spelling and grammar #28138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I saw this yesterday:
This PR removes all of the padding, breaking this UX feature. So I started thinking about ways to remove the extra padding, or make the extra padding less intrusive while still keeping this UX feature. I came up with 2 ideas:
@Tantacrul what do you think of these 2 ideas? |
@Tantacrul I've updated the code to allow 30% extra space when zooming in and out, but constrain the canvas to have a very small amount of extra space when panning. Is this good? |
@godalming123 - as far as I can tell, it's exactly the same. There's far too tight a space around the score when zoomed in. Why do we want to do this? It feels restrictive for no purpose I can discern. |
There should be extra space when you zoom in with your cursor outside the score:
I don't want to have extra space when panning so that in the future I can add a feature where when there is no vertical scroll space and you use the scroll wheel, muse score can scroll horizontally without you having to press shift. This feature would be incredibly useful for continuous view. |
There's no value in zooming on a blank space. It's just too tight. I don't understand why it needs to be so tight or what value that brings. Just make it far less tight. |
Also refactors score movement handling code, removes unused Limit scroll area to page borders checkbox, and fixes a spelling error and a grammar error
src/framework/dockwindow/thirdparty/KDDockWidgets/src/private/quick/FrameQuick_p.h
Show resolved
Hide resolved
@Tantacrul Do you agree with the removal of the |
…ordinates of the top left of the viewport
This PR is the successor to #28072.