Skip to content

Conversation

godalming123
Copy link

@godalming123 godalming123 commented May 17, 2025

Resolves: #11325 and reduces repetitive code to handle score movement

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Member

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked the design team to check whether this achieves the desired behaviour (also partly to be sure that the "desired" behaviour specified back then is still actually desired).

Meanwhile, some code comments below.

@godalming123
Copy link
Author

@cbjeukendrup thanks for your suggestions, they should all be followed now.

@godalming123
Copy link
Author

godalming123 commented May 24, 2025

I've squashed and rebased this patch with the commits from the latest upstream master to fix visual test failure. Here is the new PR: #28138.

@cbjeukendrup
Copy link
Member

(Hint for next time: rebasing and then force-pushing the existing branch is preferred over creating a new PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Continuous View - Whitespace
2 participants