Scroll space in Continuous View #21241
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
reviewed
Feb 4, 2024
| // contentRect is Vertically or Horizontally larger than viewport | ||
| // 1) Continuous Horizontal View | ||
| if (notation()->viewMode() == engraving::LayoutMode::LINE && viewport.width() < contentRect.width()) { | ||
| return notationContentRect().adjusted(0, -overscrollY, 0, overscrollY); |
There was a problem hiding this comment.
This solution has two potential disadvantages:
- if
viewport.width() < contentRect.width()andviewport.height() < contentRect.height(), you would expect that the non-adjustednotationContentRect()is returned, but instead you getnotationContentRect().adjusted(0, -overscrollY, 0, overscrollY); - if
viewport.width()is just slightly larger thancontentRect.width(), then it will immediately be possible to scroll all the way past the end of the notation.
Would it be an idea to change only the line where overscrollFactor is defined, so that it is SCROLL_LIMIT_OFF_OVERSCROLL_FACTOR when the scroll area is not limited and the view mode is not continuous view, and 0.0 otherwise?
There was a problem hiding this comment.
Change in overscrollFactor conflicts with possible zoom out percentage. To overcome removing zoom out percentages, I implemented user can scroll horizontally or vertically to page border only if page fits into viewbox. If page is smaller than view box than he can scroll outside as well.
I will look into your idea once again
fa1f8d3 to
525a11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #11325