-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add Tauri Build #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most of this works already, but we'd need to modify the redirectUri to get back a token from the user's authorization server. Two ways to do this are deep linking and a temp redirect server. Deep-linking: Requires some json to be stored server-side, like what oauth-client does. But AFAIU, atproto's oauth spec allows a different scheme for native redirectUri's ( Redirect server: Spawns a server to handle the callback. Would need to change how |
open fails on android
comments in PR
I put the client metadata for tauri in static/oauth-client-native.json so it gets bundled into tauri's binary. Tradeoff is that the domain is fixed across dev.roomy.chat and roomy.chat. Deep links from either url work, so it could be fetched/changed dynamically. Not sure if there's anything showing up in the app to use as a condition for that. |
That sounds good for now. 👌 Don't worry about fixing / debugging the issue with the Is there anything else outstanding to do on this? |
@zicklag Just the key setup for android, but that isn't something I can do on my end. I haven't done any tests with beyond signing in because of the Automerge issue. Other than that should be ready to go. |
Merging it will break the rest of the app though because the automerge imports are commented out. I could undo that in the PR and leave a note for anyone trying to test it out |
That's fine, we can do that once we're ready to publish to android.
Ah, yeah, that sounds good. 👍 |
This reverts commit 5c17e33.
❌ Deploy Preview for roomy-dev failed.
|
Sets up roomy to be built as a tauri app. Roomy successfully builds with Tauri, but is not fully usable as is.
Bugs / To-dos:
next
is imported from@automerge/automerge
, even while displaying fine from the same dev server in a browser window{ atproto } from '$lib/atproto.svelte.ts'
isundefined
in final builds (but present in dev)There's a script (
setup-tauri.sh
) to generate icons and the android build that add a lot of extra generated files to the repo. Depending on how the binaries eventually get built in CI, it might be better to add these into the repo otherwise they can just stay as part of setup.