[charts] Support lines with different domain #10801
Conversation
|
Deploy preview: https://deploy-preview-10801--material-ui-x.netlify.app/ Updated pages: |
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
I don't know both make sense. There is already a difference since
Found easier solution: if the formatted value is |
docs/data/charts/lines/lines.md
Outdated
| @@ -52,6 +52,16 @@ By default, they are stacked in the order you defined them, with positive values | |||
|
|
|||
| For more information, see [stacking docs](/x/react-charts/stacking/). | |||
|
|
|||
| ## Missing data | |||
There was a problem hiding this comment.
Another sentence explaining that shorter daŧa will automatically filled with null could be nice
There was a problem hiding this comment.
They are not, it's just that data[10] returns undefined if data has less than 10 items.
Basically it's the reason why I use == instead of ===
There was a problem hiding this comment.
OK technically they are not filled.
But my point is just that we suppor correctly data of different length, we can see it in the example, but the text does not make it clear.
There was a problem hiding this comment.
👍 It was to be sure that it's not an issue for you that I play with those undefined/null distinction
There was a problem hiding this comment.
I don't have a good enough understanding of the charts DX to have a good opinion here.
For me undefined and null don't have the same meaning so it make sense to differentiate them.
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Fix #10785