Skip to content

[DataGrid] Fix column header sortable classname when using disableColumnSorting #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

[DataGrid] Fix column header sortable classname when using disableColumnSorting #19222

merged 1 commit into from
Aug 18, 2025

Conversation

wilcoschoneveld
Copy link
Contributor

@wilcoschoneveld wilcoschoneveld commented Aug 18, 2025 •
edited
Loading

Fixes #19133

@mui-bot
Copy link

mui-bot commented Aug 18, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19222--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+37B(+0.01%) 🔺+12B(+0.01%)
@mui/x-data-grid-pro 🔺+38B(+0.01%) 🔺+16B(+0.01%)
@mui/x-data-grid-premium 🔺+38B(+0.01%) 🔺+27B(+0.02%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 65896d4

@wilcoschoneveld wilcoschoneveld mentioned this pull request Aug 18, 2025
Closed
@wilcoschoneveld wilcoschoneveld force-pushed the disable-column-sorting-classname branch from 899a763 to 65896d4 Compare August 18, 2025 08:47
@michelengelen michelengelen added scope: data grid Changes related to the data grid. feature: Sorting Related to the data grid Sorting feature type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 18, 2025
cherniavskii
cherniavskii approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cherniavskii cherniavskii merged commit 07d6f82 into mui:master Aug 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
feature: Sorting Related to the data grid Sorting feature scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] column headers still have columnHeader--sortable class when using disableColumnSorting
4 participants
@wilcoschoneveld @mui-bot @cherniavskii @michelengelen