[tree view] Don’t overwrite childrenIds when collapsed to preserve indeterminate state of the parent #19196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state of the parent
|
Deploy preview: https://deploy-preview-19196--material-ui-x.netlify.app/ Bundle size report
|
noraleonte
approved these changes
Aug 15, 2025
…-parent-is-collapsed-the-parent-node-sometimes-displays-as-unselected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19191
Repro: select a child so its parent becomes indeterminate, collapse that parent, then expand a different top-level node => the original parent flips to unchecked.
Fix: skip the childrenIds update when the item is collapsed (aria-expanded="false"), preserving previousChildrenIds and the correct indeterminate UI.
Tests: Added regression tests (3-level included)
Before
https://github.com/user-attachments/assets/9e4cdf1f-6438-4474-b2af-429de170d0db
After
https://github.com/user-attachments/assets/941d3b98-9177-4638-be20-03e7e4715737