[code-infra] Fix fs-extra removal from formattedTSDemos script
#19132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-19132--material-ui-x.netlify.app/ Bundle size report
|
fs-extra removal from formattedTSDemos.jsfs-extra removal from formattedTSDemos script
brijeshb42
approved these changes
Aug 11, 2025
|
Will be good to create a followup issue in |
Sounds good. I'll create the issue in a bit. |
Janpot
reviewed
Aug 11, 2025
| @@ -90,7 +91,7 @@ const previewOverride = { | |||
| async function transpileFile(tsxPath, program, ignoreCache = false) { | |||
| const jsPath = tsxPath.replace(/\.tsx?$/, '.js'); | |||
| try { | |||
| if (!ignoreCache && (await fs.promises.exists(jsPath))) { | |||
| if (!ignoreCache && (await fse.exists(jsPath))) { | |||
There was a problem hiding this comment.
Consider removing the exists check altogether, .stat already does the same thing
if (!ignoreCache) {
const ignoreNotFound = (err) => err.code === 'ENOENT' ? null : Promise.reject(err);
const [jsStat, tsxStat] = await Promise.all([
fs.promises.stat(jsPath).catch(ignoreNotFound),
fs.promises.stat(tsxPath).catch(ignoreNotFound),
]);
if (jsStat && tsxStat && jsStat.mtimeMs > tsxStat.mtimeMs) {
// JavaScript version is newer, skip transpiling
return TranspileResult.Skipped;
}
}or use Promise.allSettled.
There was a problem hiding this comment.
Yeah, I'm aware. Just want to fix this regression asap and I'll take a deeper look into how we can remove fs-extra and exists calls.
|
fs-extra removal from formattedTSDemos scriptfs-extra removal from formattedTSDemos script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I introduced in #19127.
fs.existsis valid, butfs.promises.existsdoesn't exist sincefs.existsis deprecated.Reverting to
fs-extra's version for now. I'll look into removing it later.