Skip to content

Conversation

bernardobelchior
Copy link
Member

Noticed that getJsdocDefaultValue isn't being used and it's the only reference to doctrine in our codebase, so we can remove it.

@bernardobelchior bernardobelchior requested a review from a team August 11, 2025 16:04
@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: code-infra Changes related to the core-infra product. labels Aug 11, 2025
@mui-bot
Copy link

mui-bot commented Aug 11, 2025

Deploy preview: https://deploy-preview-19139--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 6784d99

@bernardobelchior
Copy link
Member Author

Had to re-add @types/doctrine because test_types was failing.

@bernardobelchior bernardobelchior merged commit 8465f86 into mui:master Aug 12, 2025
20 checks passed
@bernardobelchior bernardobelchior deleted the remove-doctrine branch August 12, 2025 07:37
@zannager zannager changed the title [infra] Remove unused code and dependency [code-infra] Remove unused code and dependency Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Changes related to the core-infra product. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants