Skip to content

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 11, 2025

Context, I have spent some time to dive into the product backlog labeling health:

  1. I create filters that allows us to find all the issues without a product scope label: https://www.notion.so/mui-org/product-GitHub-community-issues-PRs-Tier-1-12a84fdf50e44595afc55343dac00fca?source=copy_link#24bcbfe7b66080f19ad0d207c9e5ce1a. Then fixed them to get to zero.
    But I gave up on covering material-ui repo, it would have taken a whole day 😀.
  2. I fixed all the issues with more than one label type. From which, it seems clear that expected behavior and duplicate label should be "type" labels because they are mutually exclusive with the other type labels. And with this larger diversity of types labels, adding the type: prefix now feels like a clear win.

However, it feels like there are too many of them that have the wrong type, e.g.:

So I think we should normalize back to what the other repositories do. We tried with mui/mui-x, but it looks like the probabilities are something like this:

  • user developers apply the right label: 40%
  • maintainer see that they needs to apply the right label when there is one applied by default 50%
  • maintainer see that they needs to apply the right label when there is none applied by default 95%
  • maintainer apply the right label: 95%

Then we can apply the math with ⬆️ values:

  1. Label by default, probability to get the right label = 0.40 * 0.50 + 0.40 * 0.50 * 0.95 + 0.60 * 0.50 * 0.95 = 0.68
  2. No labels by default, probability to get the right label = 0.95 * 0.95 = 0.90 🏆

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: support-infra Changes related to the support-infra product. labels Aug 11, 2025
@mui-bot
Copy link

mui-bot commented Aug 11, 2025

Deploy preview: https://deploy-preview-19104--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 🔺+2B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 🔺+2B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 🔺+2B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+5B(+0.01%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+1B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 4c979f3

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 11, 2025

@michelengelen you mentioned in the past that this change could negatively impact the devlake stats, is this still the case?

@michelengelen
Copy link
Member

@michelengelen you mentioned in the past that this change could negatively impact the devlake stats, is this still the case?

Not anymore... I changed the query for the metrics so it should be fine.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 11, 2025

Ok perfect. Let's go with this, I'm hopeful it will increased labels accuracy and reduce maintainer time spent on setting type labels (no need to check multiple times).

@oliviertassinari oliviertassinari merged commit fac25a0 into mui:master Aug 11, 2025
24 checks passed
@oliviertassinari oliviertassinari deleted the remove-default-label branch August 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: support-infra Changes related to the support-infra product. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants