Skip to content

[tree view] Fix root not loading from cache on remount #19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2025
Merged

[tree view] Fix root not loading from cache on remount #19088

merged 2 commits into from
Aug 15, 2025

Conversation

noraleonte
Copy link
Contributor

Part of #19022

@noraleonte noraleonte requested a review from rita-codes August 7, 2025 11:39
@noraleonte noraleonte self-assigned this Aug 7, 2025
@noraleonte noraleonte added type: bug It doesn't behave as expected. scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. labels Aug 7, 2025
@noraleonte noraleonte mentioned this pull request Aug 7, 2025
Open
@mui-bot
Copy link

mui-bot commented Aug 7, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19088--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid/DataGrid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro/DataGridPro 0B(0.00%) 🔺+1B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium/DataGridPremium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 🔺+44B(+0.07%) 🔺+14B(+0.08%)
@mui/x-tree-view-pro 🔺+191B(+0.24%) 🔺+45B(+0.18%)

Details of bundle changes

Generated by 🚫 dangerJS against 2c75e02

@oliviertassinari oliviertassinari changed the title [Tree View] Fix root not loading from cache on remount [tree view] Fix root not loading from cache on remount Aug 9, 2025
rita-codes
rita-codes approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@rita-codes rita-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

I’m fine with the initial collapse behavior as a first step, as we discussed we can iterate later to find a better solution 🙌

Thanks for taking care of this!

@noraleonte noraleonte merged commit 389aaee into mui:master Aug 15, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rita-codes rita-codes rita-codes approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees

@noraleonte noraleonte

Labels
scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noraleonte @mui-bot @rita-codes