[internals] remove dependency on @mui/system
#19062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
reviewed
Aug 5, 2025
packages/x-virtualizer/package.json
Outdated
Comment on lines
40
to
45
| "@babel/runtime": "^7.27.4", | ||
| "@mui/x-internals": "workspace:*" | ||
| "@babel/runtime": "^7.27.4" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "^17.0.0 || ^18.0.0 || ^19.0.0", | ||
| "react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0" | ||
| "react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0", | ||
| "@mui/x-internals": "workspace:*" |
There was a problem hiding this comment.
Why does it need to be in peer dependencies?
There was a problem hiding this comment.
Because it brings its own peer dependencies with it. It is easier to just pass it up to data-grid because that package also depends on x-internals.
There was a problem hiding this comment.
I don't see @mui/system being used in @mui/x-internals anymore. That dependency was introduced for the type import in this file, but that type import is gone now. If we remove @mui/system from @mui/x-internals peer dependencies, would that solve the issue?
There was a problem hiding this comment.
actually yes. That would solve it. I'll update the pr.
x-internals to peerDependenciesx-internals to peerDependencies
x-internals to peerDependencies@mui/system
romgrk
approved these changes
Aug 5, 2025
|
Deploy preview: https://deploy-preview-19062--material-ui-x.netlify.app/ Bundle size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19061