Skip to content

[DataGridPro] Fix row reorder not working with column reorder disabled #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 5, 2025
Merged

[DataGridPro] Fix row reorder not working with column reorder disabled #19016

merged 11 commits into from
Aug 5, 2025

Conversation

MBilalShafi
Copy link
Member

Fix #18889

@MBilalShafi MBilalShafi added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. feature: Reordering Related to the data grid Reordering feature labels Aug 1, 2025
@mui-bot
Copy link

mui-bot commented Aug 1, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19016--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 🔺+61B(+0.02%) 🔺+14B(+0.01%)
@mui/x-data-grid/DataGrid 🔺+61B(+0.02%) 🔺+33B(+0.03%)
@mui/x-data-grid-pro 🔺+325B(+0.07%) 🔺+95B(+0.07%)
@mui/x-data-grid-pro/DataGridPro 🔺+322B(+0.07%) 🔺+71B(+0.05%)
@mui/x-data-grid-premium 🔺+319B(+0.05%) 🔺+129B(+0.08%)
@mui/x-data-grid-premium/DataGridPremium 🔺+320B(+0.06%) 🔺+101B(+0.06%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-1B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a26dd02

@MBilalShafi MBilalShafi marked this pull request as ready for review August 4, 2025 09:46
@MBilalShafi MBilalShafi mentioned this pull request Aug 4, 2025
Merged
19 tasks
cherniavskii
cherniavskii approved these changes Aug 4, 2025
View reviewed changes
@cherniavskii cherniavskii added the plan: Pro Impact at least one Pro user. label Aug 4, 2025
@cherniavskii cherniavskii changed the title [DataGrid] Fix row reorder not working with column reorder disabled [DataGridPro] Fix row reorder not working with column reorder disabled Aug 4, 2025
@MBilalShafi MBilalShafi enabled auto-merge (squash) August 5, 2025 06:20
@MBilalShafi MBilalShafi merged commit 843c35f into mui:master Aug 5, 2025
20 checks passed
@MBilalShafi MBilalShafi deleted the fix-row-reorder-issue branch August 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@arminmeh arminmeh Awaiting requested review from arminmeh

Assignees
No one assigned
Labels
feature: Reordering Related to the data grid Reordering feature plan: Pro Impact at least one Pro user. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Row reordering not working on cells with column reorder disabled
3 participants
@MBilalShafi @mui-bot @cherniavskii