[DataGrid] Fix performance issue for root level "select all" #19015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-19015--material-ui-x.netlify.app/ Bundle size report
|
arminmeh
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19001
Before: https://stackblitz.com/edit/ddumkzun-fz2hksdw
After: https://stackblitz.com/edit/ddumkzun-iv8mn7xq
Changes done
This PR fix two things:
Follow up
A part of the performance issue still remains in this line:
mui-x/packages/x-data-grid/src/hooks/features/rowSelection/utils.ts
Line 147 in 89fae6a
Specifically, the
.filter()operation runs on all rows at a level, but now only for rows withdepth > 0. In most cases, we can assume that the number of children (not descendents) under a given parent remains within a safe range (or else server-side data should be used).However, we should still work on introducing partial dictionaries where possible to improve performance for these cases.