Skip to content

[code-infra] Migrate build command to code-infra #19006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

[code-infra] Migrate build command to code-infra #19006

merged 1 commit into from
Aug 14, 2025

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Aug 1, 2025 •
edited
Loading

See original PR - mui/mui-public#408 for full context and description.

  • Added explicit /* export path in relevant package's exports field.
  • Major change is in babel config where the loose mode plugins have been removed. Only the spread operator transform plugin is retained (comment).
assumptions: {
  setPublicClassFields: true,
  privateFieldsAsProperties: true,
  objectRestNoSymbols: true,
},

Some of the differences due to the new babel config -

  1. Only esm build is affected.

Old -

export class NestedDataManager {
  constructor(instance, maxConcurrentRequests = MAX_CONCURRENT_REQUESTS) {
    this.pendingRequests = new Set();
    this.queuedRequests = new Set();
    this.settledRequests = new Set();
}

New -

export class NestedDataManager {
  pendingRequests = (() => new Set())();
  queuedRequests = (() => new Set())();
  settledRequests = (() => new Set())();
}
  1. Same, only esm build is affected. Saves some bytes.

Old

export class UserGesture {
  constructor(pointerType) {
    this.pointerManager = void 0;
    this.advanceTimers = void 0;
    this.pointerManager = new PointerManager(pointerType);
  }
}

New

export class UserGesture {
  constructor(pointerType) {
    this.pointerManager = new PointerManager(pointerType);
  }
}
  1. Removal of .css imports in .d.ts files. It was unnecessary.

@brijeshb42 brijeshb42 added the scope: code-infra Changes related to the core-infra product. label Aug 1, 2025
@brijeshb42 brijeshb42 mentioned this pull request Aug 1, 2025
Merged
2 tasks
@mui-bot
Copy link

mui-bot commented Aug 1, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19006--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid ▼-358B(-0.09%) ▼-45B(-0.04%)
@mui/x-data-grid-pro ▼-504B(-0.11%) ▼-42B(-0.03%)
@mui/x-data-grid-premium ▼-551B(-0.09%) ▼-62B(-0.04%)
@mui/x-charts ▼-1.94KB(-0.61%) ▼-111B(-0.12%)
@mui/x-charts-pro ▼-2.24KB(-0.56%) ▼-145B(-0.12%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view ▼-98B(-0.17%) ▼-15B(-0.08%)
@mui/x-tree-view-pro ▼-214B(-0.27%) ▼-15B(-0.06%)

Details of bundle changes

Generated by 🚫 dangerJS against 85eb1a6

@brijeshb42 brijeshb42 added scope: code-infra Changes related to the core-infra product. and removed scope: code-infra Changes related to the core-infra product. labels Aug 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 1, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 7, 2025
@brijeshb42 brijeshb42 force-pushed the migrate-build branch 10 times, most recently from 501328d to d655e9b Compare August 8, 2025 13:42
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 10, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Aug 11, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Aug 11, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@brijeshb42 brijeshb42 force-pushed the migrate-build branch 4 times, most recently from c4ff207 to d2a1c7a Compare August 12, 2025 17:30
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 14, 2025
@brijeshb42
Copy link
Contributor Author

brijeshb42 commented Aug 14, 2025 •
edited
Loading

Hey folks. I've added some of the differences in the new output in the PR description. Everything else is same as I tested locally in the output changes.
Let me know if you feel differently and I can add the other babel transforms plugins back, but to point out, this has been working on core repo for quite a long time.

@brijeshb42 brijeshb42 requested a review from romgrk August 14, 2025 11:01
@brijeshb42 brijeshb42 merged commit f9075b2 into mui:master Aug 14, 2025
20 checks passed
@brijeshb42 brijeshb42 deleted the migrate-build branch August 14, 2025 14:16
@zannager zannager changed the title [infra] Migrate build command to code-infra [code-infra] Migrate build command to code-infra Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@Janpot Janpot Janpot approved these changes

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
scope: code-infra Changes related to the core-infra product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brijeshb42 @mui-bot @romgrk @Janpot @bernardobelchior @cherniavskii