-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[docs] Add demo frame to Data Grid demos (DX-34) #18994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-18994--material-ui-x.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The layout + route changes look good 👍
data-ga-event-label={demoName} | ||
data-ga-event-action="github" | ||
onClick={() => { | ||
// TODO: Link to GitHub repos / stackblitz / codesandbox ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning on adding this in this PR?
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Preview: https://deploy-preview-18994--material-ui-x.netlify.app/x/react-data-grid/demos/real-time-data/
Based on https://mui.com/material-ui/getting-started/templates/dashboard/ - overriding the docs layout so the Data Grid demos can take most of the viewport.
I added a placeholder GitHub button and think we could do some bullet points for the features used in each demo.