Skip to content

[infra] Fix markdown formatting in llms generation #18914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

[infra] Fix markdown formatting in llms generation #18914

merged 2 commits into from
Jul 25, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 25, 2025 •
edited by mbrookes
Loading

The prettier.resolveConfig expects the file you want to format, not what you think is the config file.

Seeing warnings like:

Warning: Could not format markdown with prettier: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/janpotoms/Projects/mui-x/prettier.config.js' imported from /Users/janpotoms/Projects/mui-x/node_modules/.pnpm/prettier@3.6.2/node_modules/prettier/index.mjs
    at finalizeResolution (node:internal/modules/esm/resolve:274:11)
    at moduleResolve (node:internal/modules/esm/resolve:859:10)
    at defaultResolve (node:internal/modules/esm/resolve:983:11)
    at nextResolve (node:internal/modules/esm/hooks:748:28)
    at resolveBase (file:///Users/janpotoms/Projects/mui-x/node_modules/.pnpm/tsx@4.20.3/node_modules/tsx/dist/esm/index.mjs?1753456976164:2:3811)
    at async resolveDirectory (file:///Users/janpotoms/Projects/mui-x/node_modules/.pnpm/tsx@4.20.3/node_modules/tsx/dist/esm/index.mjs?1753456976164:2:4304)
    at async resolve (file:///Users/janpotoms/Projects/mui-x/node_modules/.pnpm/tsx@4.20.3/node_modules/tsx/dist/esm/index.mjs?1753456976164:2:5422)
    at async nextResolve (node:internal/modules/esm/hooks:748:22)
    at async Hooks.resolve (node:internal/modules/esm/hooks:240:24)
    at async handleMessage (node:internal/modules/esm/worker:199:18) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///Users/janpotoms/Projects/mui-x/prettier.config.js'
}

PSA: Claude Code tries to silence errors as much as possible, please be mindful of this. We want the build to fail when something unexpected happens, not some warning nobody notices when it happens in CI. I'm replacing all of those with errors, and fixing a problem with date pickers api that it uncovered.

@Janpot Janpot added the scope: code-infra Changes related to the core-infra product. label Jul 25, 2025
@mui-bot
Copy link

mui-bot commented Jul 25, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18914--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid/DataGrid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro/DataGridPro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium/DataGridPremium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 81e36ef

@Janpot Janpot added the type: bug It doesn't behave as expected. label Jul 25, 2025
@Janpot Janpot marked this pull request as ready for review July 25, 2025 16:11
@Janpot Janpot requested a review from a team July 25, 2025 16:11
@Janpot Janpot merged commit 7c6a52a into mui:master Jul 25, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav-is dav-is dav-is approved these changes

Assignees
No one assigned
Labels
scope: code-infra Changes related to the core-infra product. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @dav-is