[DataGrid] Set correct data source cache chunk size when pagination is disabled #18636
Conversation
|
Deploy preview: https://deploy-preview-18636--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 🔺+534B(0.00%) - Total Gzip Change: 🔺+195B(0.00%) Show details for 100 more bundles (22 more not shown)@mui/x-data-grid parsed: 🔺+89B(+0.02%) gzip: 🔺+45B(+0.04%) |
packages/x-data-grid-pro/src/tests/dataSource.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid-pro/src/tests/dataSource.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid/src/hooks/features/dataSource/useGridDataSourceBase.ts
Outdated
Show resolved
Hide resolved
f6467d2 to
9d23103
Compare
Fixes #18611
If the user does not use pagination model in request params to generate the response, the grid will have the default pagination model in the state, but all the data will be retrieved in one request (pageSize = 100 -> 1000 rows retrieved).
Our chunk manager would create only one chunk, but it would slice the data as it would make 10.
The update makes the chunk manager take the whole data if there is only one chunk to be generated (covers the scenario from above)
Lazy loading is not affected, because you have to use start and end parameters, which are then correctly used by the chunk manager to prepare chunks upfront. I have added a test where we retrieve 3 pages at once and later ask for the first page only.