You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the display position of the drop indicator, it should be shown where the border is closer
Handle auto height with above
Analyze performance impact for the animation
Fix: The last drop indicator doesn't show
Fix tests
Follow-ups
Move drop indicator in the scroll direction on scroll over <GridScrollArea />
Changelog
✨ Improve the drag and drop interaction for Data Grid row reordering feature. It uses a drop indicator to point to the position the row would be moving to.
designThis is about UI or UX design, please involve a designer.feature: ReorderingRelated to the data grid Reordering featureplan: ProImpact at least one Pro user.scope: data gridChanges related to the data grid.type: enhancementIt’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Explored a bit about it in #18251 as a potentially improved UX:
dragOver, only add a drop indicator at the place where the row would moverowDragEnddidn't fire on the row virtualized out.Previews:
Before: https://deploy-preview-18810--material-ui-x.netlify.app/x/react-data-grid/row-ordering/
After: https://deploy-preview-18627--material-ui-x.netlify.app/x/react-data-grid/row-ordering/
To Dos:
Fix top border jumprowDragEndnot firing for unmounted rows (inspiration from [DataGridPro] Fix row ordering not auto-scrolling when moving beyond viewport #18557 (comment))Follow-ups
<GridScrollArea />Changelog
✨ Improve the drag and drop interaction for Data Grid row reordering feature. It uses a drop indicator to point to the position the row would be moving to.
row-reordering-ux-improvement.mov