[docs] Add CSS bundler breaking change to migration guide #17436
Conversation
|
Deploy preview: https://deploy-preview-17436--material-ui-x.netlify.app/ Updated pages: Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) Show details for 100 more bundles (22 more not shown)@mui/x-charts parsed: 0B(0.00%) gzip: 0B(0.00%) |
| ### Bundling | ||
|
|
||
| The Data Grid now requires a bundler that can handle CSS imports. | ||
|
|
There was a problem hiding this comment.
Let's cover some popular setups here.
- Next.js Pages router: [data grid][docs] CSS loader needed for x-data-grid v8.0.0? #17427 (comment)
- Webpack
- Vitest [data grid][docs] CSS loader needed for x-data-grid v8.0.0? #17427 (comment)
- ?
There was a problem hiding this comment.
What level of detail do you have in mind? Just a link?
There was a problem hiding this comment.
Something like https://mui.com/x/migration/usage-with-material-ui-v5-v6/, with code snippets and links
There was a problem hiding this comment.
I've added snippets here, but should we move them somewhere in the docs and link to there instead? Maybe the quickstart section?
|
cc @DiegoAndai |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This looks aligned with our results from testing different bundlers, so LGTM from my side. Core won't need a breaking changes guide, but we plan to have an integration guide for popular bundlers, similar to https://react-spectrum.adobe.com/react-spectrum/ssr.html#nextjs. We haven't added yet. cc @brijeshb42 may I ask you to test and add a Webpack row to our table? |
|
I am surprised I left out Webpack. Will add it. Also, it'll be a good idea to centralise this later in the core docs integrating the findings here which the X docs can just link to instead of duplicating. |
docs/data/migration/migration-data-grid-v7/migration-data-grid-v7.md
Outdated
Show resolved
Hide resolved
…-v7.md Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
|
This pull request has been closed due to 15 days of inactivity after being marked stale. |
|
This seems worth merging? |
|
I've added a section on ESM loader hooks. Can someone review & approve this PR? |
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
Follow-up of #17427