[DataGrid] New Toolbar component #14611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-14611--material-ui-x.netlify.app/ Updated pages: |
This was referenced Oct 16, 2024
Merged
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
packages/x-data-grid/src/components/quickFilter/QuickFilter.tsx
Outdated
Show resolved
Hide resolved
arminmeh
reviewed
Feb 27, 2025
arminmeh
reviewed
Feb 27, 2025
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
arminmeh
approved these changes
Feb 27, 2025
|
Besides the latest open points LGTM |
MBilalShafi
reviewed
Feb 27, 2025
Comment on lines
+16
to
+18
| <ColumnsPanelTrigger render={<ToolbarButton />}> | ||
| <ViewColumnIcon fontSize="small" /> | ||
| </ColumnsPanelTrigger> |
There was a problem hiding this comment.
If I understood correctly, it makes more sense to use render prop if there's a need to access props or state.
<ColumnsPanelTrigger render={(props) => <ToolbarButton {...props} />}>
<ViewColumnIcon fontSize="small" />
</ColumnsPanelTrigger>Is it possible to skip the render prop for simple use cases?
<ColumnsPanelTrigger>
<ToolbarButton>
<ViewColumnIcon fontSize="small" />
</ToolbarButton>
</ColumnsPanelTrigger>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a redesigned Toolbar component through a new composition API, documented here:
There are several related components that users can use to build a custom toolbar:
Note
This PR only adds the building blocks to create custom toolbars, and documentation for those components. I'm hoping we can release these in v7 for users to try out. There will be a follow up to update the default grid toolbar for v8 to use the new components. #15823
Closes #11584
Follow-up tasks:
QuickFiltercomponents inGridToolbarQuickFilter