Skip to content

Conversation

apedroferreira
Copy link
Collaborator

@apedroferreira apedroferreira commented May 15, 2025

Closes #4825

Uses renderCell to make the id column in CRUD List pages work as a link.
Changes component props accordingly, as onRowClick is not needed or used anymore.

Screen.Recording.2025-05-15.at.18.50.54.mov

https://deploy-preview-4943--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/
https://deploy-preview-4943--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/#list-component

@apedroferreira apedroferreira self-assigned this May 15, 2025
@apedroferreira apedroferreira added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: toolpad-core Abbreviated to "core" component: crud labels May 15, 2025
@mui-bot
Copy link

mui-bot commented May 15, 2025

Netlify deploy preview

https://deploy-preview-4943--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 842dd9b

@apedroferreira apedroferreira marked this pull request as draft May 15, 2025 18:05
@apedroferreira apedroferreira marked this pull request as ready for review May 20, 2025 10:19
@apedroferreira apedroferreira requested a review from a team May 20, 2025 10:22
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 22, 2025
@apedroferreira
Copy link
Collaborator Author

We've decided to prioritize a good UX by allowing users to click a whole row instead of linking from a single cell.
Will address specific concerns in #4825 separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged. scope: toolpad-core Abbreviated to "core" type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRUD] Fix accessibility of rows in Crud component
2 participants