Skip to content

[docs] Fix build errors with Next.js 14 #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2025
Merged

[docs] Fix build errors with Next.js 14 #4594

merged 1 commit into from
Jan 12, 2025

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Jan 12, 2025 •
edited
Loading

  • Fixes Version 0.12.0 breaks docs #4585
  • The build succeeds but the built site doesn't hydrate
  • Upgrading to Next.js 15 fixes this
  • Also remove unused @types/react-router-dom

@bharatkashyap bharatkashyap added docs Improvements or additions to the documentation. type: regression A bug, but worse, it used to behave as expected. labels Jan 12, 2025
@mui-bot
Copy link

mui-bot commented Jan 12, 2025

Netlify deploy preview

https://deploy-preview-4594--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 5babdf9

@bharatkashyap bharatkashyap requested a review from a team January 12, 2025 04:27
prakhargupta1
prakhargupta1 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@prakhargupta1 prakhargupta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the demos are working in this PR.

@bharatkashyap bharatkashyap merged commit 88ba6ce into mui:master Jan 12, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation. type: regression A bug, but worse, it used to behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 0.12.0 breaks docs
3 participants
@bharatkashyap @mui-bot @prakhargupta1