Parallel solving #7838
Merged
Parallel solving #7838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#7743 Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
…pressions Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
axioms for len(substr(...)) escaped due to nested rewriting
add simplification rule for at(x, offset) = "" Introducing j just postpones some rewrites that prevent useful simplifications. Z3 already uses common sub-expressions. The example highlights some opportunities for simplification, noteworthy at(..) = "". The example is solved in both versions after adding this simplification.
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
add pre-processing simplification
fix incrementality bugs by allowing destructive updates during saturation at the cost of redoing saturation after a pop.
…digm, need to debug as I am getting segfault still
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
…ng deepest cubes only
…can. the PQ implementation backend still remains in case we want to switch back
…stalled (Z3Prover#7815) * fix: add generating META for ocamlfind. * Patch macos. We need to keep the `@rpath` and use environment var to enable the test because we need to leave it to be fixed by package managers. * Trigger CI. * Debug. * Debug. * Debug. * Debug. * Debug. * Debug. * Hacky fix for ocaml building warning. * Fix typo and rename variables. * Fix cmake for ocaml test, using local libz3 explicit.
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
…e error: ASSERTION VIOLATION File: /home/t-ilshapiro/z3/src/ast/ast.cpp Line: 388 UNEXPECTED CODE WAS REACHED. I left a comment on the line where it's crashing
…ven if we don't split it further
…approach is actually unsound, but I am going to focus on the PQ approach for now since it has more potential for SAT problems with the right hardness metric
6757007 to
a3024b7
Compare
… march, need to re-examine/debug/evaluate
f7fa7dd to
042ebf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PQ is working with naive hardness metric (sorted by cube depth). the depth sets approach is actually not sound (there is some bug) but I am going to focus on the PQ because this data structure has more potential to help for SAT problems with the right hardness metric