Skip to content

Not scan files on git version < 1.8.5 #220

@killuazhu

Description

@killuazhu

Git version before 1.8.5 does not support -C <path> option.

When running detect-secrets with pre-1.8.5 git version, _get_git_tracked_files would return None since the exception is silently ignored. This causes non of the tracked files been scanned.

git help on 1.8.3

$ git help
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueThe issue can be tackled by someone who has little to no knowledge about the project.help wantedIndicates that we would like someone that’s not a maintainer to work on the issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions