feat: add time filter option #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new time-based filtering option to allow CLI consumers to restrict event processing by start/end timestamps or recent time offsets.
- Introduces
TimeOptionincli.rswith new flags for--timeline-start,--timeline-end, and--time-offset - Implements
filter_by_timeintimefiler.rsand integrates it intoaws_summary,aws_metrics, andaws_detect - Updates
main.rsand module exports to wire the new filtering option through the existing commands
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/option/cli.rs | Define new TimeOption struct and CLI flags |
| src/option/timefiler.rs | Implement time parsing and filtering logic |
| src/option.rs | Export the new timefiler module |
| src/main.rs | Update calls to aws_metrics and aws_summary to use TimeOption |
| src/cmd/aws_summary.rs | Apply filter_by_time before summary processing |
| src/cmd/aws_metrics.rs | Apply filter_by_time before metrics processing |
| src/cmd/aws_detect.rs | Apply filter_by_time in detection pipeline |
Comments suppressed due to low confidence (2)
src/option/timefiler.rs:1
- [nitpick] The module and file are named
timefiler.rs, but the feature is a time filter. Consider renaming totimefilter.rsand the module totimefilterfor clarity.
use crate::option::cli::TimeOption;
src/option/timefiler.rs:44
- There’s no test case for invalid
time_offsetvalues (e.g., malformed strings). Add a test to ensurefilter_by_timereturns false whentime_offsetfails to parse.
fn parse_offset(offset: &str) -> Option<Duration> {
aws-ct-timeline --timeline-offset |
aws-ct-summary --timeline-start |
aws-ct-metrics --timeline-end |
YamatoSecurity
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
aws-ct-timelinetime filtering #58Evidence
aws-ct-timeline
aws-ct-summary
aws-ct-metrics
I’d appreciate it if you could check it when you have time🙏