Skip to content

fix #179 Create a Computer Summary page #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

nishikawaakira
Copy link
Collaborator

#179 is now fix. Please check
Screenshot 2024-09-07 at 11 08 07

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed Computer Summary created :) LGTM!!🚀

@YamatoSecurity
Copy link
Collaborator

@nishikawaakira Thanks so much! Looks good! Just one question, how are you sorting the computers? Shouldn't DESKTOP-CNG7416 be above MyComputer because it has 1 high alert but MyComputer does not have any critical or high alerts?

@nishikawaakira
Copy link
Collaborator Author

@YamatoSecurity
The sorting was only done by criticality, so it has been corrected to sort by all severities.
Screenshot 2024-09-08 at 8 32 02

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Sep 8, 2024
@YamatoSecurity YamatoSecurity added this to the v2.7.0 SecTor release milestone Sep 8, 2024
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishikawaakira LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 46b2334 into main Sep 8, 2024
2 checks passed
@YamatoSecurity YamatoSecurity deleted the 179-create-a-computer-summary-html branch September 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants