-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add automagic command #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@fukusuket Thanks! I just tried it on a big case and it is taking forever to print out the powershell extraction table results. I think we should print out summary information about what files were saved, file size, if there were no results, etc... but we probably shouldn't print out detailed table information as it can get too big. Maybe the table info is not as big if the minimal level is set to |
@YamatoSecurity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fukusuket Could I ask you for two things.
Before:
After:
For example:
Elapsed time: 0 hours, 17 minutes, 58 seconds (Note: some of the output file names need to be changed. Example: We should separate results in the table by return characters but it is not possible to do in the markdown table example above. Also, the file size calculation for |
@YamatoSecurity |
@YamatoSecurity hayabusa-sample-evtx
I confirmed that the integration test also passed. |
I also fixed #141 and confirmed following all command works!
|
It seems that depending on the timing, the file system may return 0 bytes even though the file actually exists, so I would like to address this as a separate issue. (It seems that it may or may not be reproduced 0 Bytes. This is the same even when executing the |
@fukusuket Thanks so much! It's looking much better now. There seem to be some conflicts that need to be resolved. |
|
Could you capitalize all letters in the file names and add the word for the command
|
@YamatoSecurity
|
Unfortunately, Nancy does not seem to support cells with line breaks, so it is difficult to insert line breaks... :( |
@fukusuket I see, that is unfortunate. Maybe we can create an issue on the Nancy repository to see if it can be supported some day? |
@fukusuket It looks like the results for the |
@YamatoSecurity |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'll try reading nancy's source code and see if there are any other workarounds...🤔 |
Windows11PowerShell
Windows Terminal
Command Prompt
|
macOSiTerm
|
Ubuntu20.04Terminal
|
@YamatoSecurity
so I tried padding it to 80 characters as a workaround. Could you please confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Thanks so much for the workaround. LGTM! It would nice to eventually have to display cleanly on powershell but is not such a big issue so I'll create a low priority issue for that.
What Changed
automagic
command #132Test
Environment
In the integration test below, I confirmed that the all commands succeeded.
https://github.com/Yamato-Security/takajo/actions/runs/8303017518