Make ResultCore move result from shared caller when possible #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16950797610Details
💛 - Coveralls |
MBkkt
reviewed
Aug 13, 2025
| @@ -13,8 +13,8 @@ using SharedContract = std::pair<SharedFuture<V, E>, SharedPromise<V, E>>; | |||
|
|
|||
| template <typename V = void, typename E = StopError> | |||
| [[nodiscard]] SharedContract<V, E> MakeSharedContract() { | |||
| // 2 refs for SharedPromise, 1 ref for SharedFuture | |||
| auto core = MakeShared<detail::SharedCore<V, E>>(3); | |||
| // 3 refs for SharedPromise, 1 ref for SharedFuture | |||
There was a problem hiding this comment.
Suggested change
| // 3 refs for SharedPromise, 1 ref for SharedFuture | |
| // 1 refs for SharedPromise, 1 ref for SharedFuture, 2 ref for last Set |
MBkkt
reviewed
Aug 13, 2025
MBkkt
reviewed
Aug 13, 2025
MBkkt
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes callback
UniqueCore/SharedCoreinstances move the result from the callerSharedCorewhen they are the last callback to ever need the value