Skip to content

Add Then for SharedFuture #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2025
Merged

Add Then for SharedFuture #264

merged 1 commit into from
Aug 16, 2025

Conversation

ocelaiwo
Copy link
Contributor

Purpose

This PR adds the ability to set up callbacks on a SharedFuture (SharedFuture::Then/ThenInline). The future is not consumed in the process.

MBkkt
MBkkt reviewed Aug 12, 2025
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16988652316

Details

  • 50 of 50 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 16976280802: 0.0%
Covered Lines: 1960
Relevant Lines: 1960
💛 - Coveralls

MBkkt
MBkkt reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with PR that fix shared future makes copy of value even when only single owner exists

@ocelaiwo ocelaiwo force-pushed the shared_core_callbacks branch 4 times, most recently from edf0258 to 7eaa44d Compare August 15, 2025 10:52
@ocelaiwo ocelaiwo force-pushed the shared_core_callbacks branch from 7eaa44d to 65d739b Compare August 15, 2025 11:02
@ocelaiwo ocelaiwo marked this pull request as ready for review August 15, 2025 11:12
@ocelaiwo ocelaiwo requested a review from kononovk as a code owner August 15, 2025 11:12
MBkkt
MBkkt approved these changes Aug 16, 2025
View reviewed changes
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more tests

  1. now we have tests that executed for Furure, andTask. We need to add SharedFuture
  2. implement detach
  3. implement await

@MBkkt MBkkt merged commit f71dbbf into YACLib:main Aug 16, 2025
34 checks passed
@ocelaiwo ocelaiwo deleted the shared_core_callbacks branch September 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBkkt MBkkt MBkkt approved these changes

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocelaiwo @coveralls @MBkkt