Skip to content

Make SharedCore into a proper core, Add Connect, Make SharedFuture waitable #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Make SharedCore into a proper core, Add Connect, Make SharedFuture waitable #259

merged 2 commits into from
Jul 30, 2025

Conversation

ocelaiwo
Copy link
Contributor

Purpose

This PR makes SharedCore into a proper core so that SharedFuture instances can be used in more situations.
Here for ResultCore is also implemented to allow it to be on the receiving end of Loop.
For now, the following is supported:

  • The use of Connect(future, promise) to use the future result to fulfill the promise (both future and promise can be either shared or regular).
  • SharedFuture instances are waitable now if the wait is performed without a timeout. SharedFuture can be waited concurrently.

@ocelaiwo ocelaiwo requested review from MBkkt and kononovk as code owners July 16, 2025 11:31
@ocelaiwo ocelaiwo marked this pull request as draft July 16, 2025 11:32
@ocelaiwo ocelaiwo force-pushed the shared_future branch 3 times, most recently from 7e8d8a1 to 9aaeb9c Compare July 17, 2025 13:10
@ocelaiwo ocelaiwo marked this pull request as ready for review July 17, 2025 13:14
@coveralls
Copy link

coveralls commented Jul 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16627608114

Details

  • 134 of 134 (100.0%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 16057692546: 0.0%
Covered Lines: 1903
Relevant Lines: 1903
💛 - Coveralls

MBkkt
MBkkt reviewed Jul 18, 2025
View reviewed changes
MBkkt
MBkkt reviewed Jul 18, 2025
View reviewed changes
MBkkt
MBkkt reviewed Jul 18, 2025
View reviewed changes
MBkkt
MBkkt reviewed Jul 18, 2025
View reviewed changes
@ocelaiwo ocelaiwo force-pushed the shared_future branch 2 times, most recently from 8396926 to 865cc17 Compare July 26, 2025 13:24
MBkkt
MBkkt reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot tests for
connect(coro(), promise)
connect(coro(), shared_promise)

MBkkt
MBkkt reviewed Jul 30, 2025
View reviewed changes
@MBkkt MBkkt merged commit a8fe5b9 into YACLib:main Jul 30, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBkkt MBkkt MBkkt left review comments

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocelaiwo @coveralls @MBkkt