Skip to content

Added co_await overload for single future (#194) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

Added co_await overload for single future (#194) #232

merged 4 commits into from
Jan 26, 2023

Conversation

harashimahashi
Copy link
Contributor

@harashimahashi harashimahashi commented Jan 24, 2023 •
edited by MBkkt
Loading

Purpose

#194

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

MBkkt
MBkkt requested changes Jan 24, 2023
View reviewed changes
MBkkt
MBkkt reviewed Jan 24, 2023
View reviewed changes
@harashimahashi harashimahashi force-pushed the 194-implement-co-await-single-future branch from f465285 to 3029d7b Compare January 25, 2023 23:08
@harashimahashi harashimahashi requested a review from MBkkt January 25, 2023 23:09
MBkkt
MBkkt reviewed Jan 25, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #232 (d415198) into main (49b5ef1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         1521      1543   +22     
=========================================
+ Hits          1521      1543   +22
Impacted Files Coverage Δ
include/yaclib/coro/await.hpp 100.00% <100.00%> (ø)
include/yaclib/coro/detail/await_awaiter.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harashimahashi harashimahashi force-pushed the 194-implement-co-await-single-future branch from 3029d7b to d415198 Compare January 25, 2023 23:55
@MBkkt MBkkt self-assigned this Jan 25, 2023
@MBkkt MBkkt merged commit 9ece55a into main Jan 26, 2023
@MBkkt MBkkt deleted the 194-implement-co-await-single-future branch December 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBkkt MBkkt MBkkt approved these changes

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harashimahashi @MBkkt