Skip to content

Add Async/Lazy Contract #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Add Async/Lazy Contract #224

merged 1 commit into from
Nov 18, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Nov 13, 2022

Purpose

  • Add AsyncContract
  • Add LazyContract
  • Fix few issues

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner November 13, 2022 23:13
@MBkkt MBkkt added the WIP Work in progress label Nov 13, 2022
@coveralls
Copy link

coveralls commented Nov 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3494038988

  • 77 of 77 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3457258136: 0.0%
Covered Lines: 1521
Relevant Lines: 1521
💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 14, 2022 •
edited
Loading

Codecov Report

Merging #224 (1bfc10c) into main (8c78ebf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1bfc10c differs from pull request most recent head 026483b. Consider uploading reports for the commit 026483b to get more accurate results

@@            Coverage Diff            @@
##              main      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        66    +2     
  Lines         1485      1520   +35     
=========================================
+ Hits          1485      1520   +35
Impacted Files Coverage Δ
include/yaclib/algo/detail/core.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/detail/func_core.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/detail/promise_core.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/when_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/run.hpp 100.00% <100.00%> (ø)
include/yaclib/async/when_all.hpp 100.00% <100.00%> (ø)
include/yaclib/async/when_any.hpp 100.00% <100.00%> (ø)
include/yaclib/lazy/detail/task_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/lazy/schedule.hpp 100.00% <100.00%> (ø)
include/yaclib/util/result.hpp 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt
Add AsyncContract
026483b 
Add LazyContract
Fix few issues
@MBkkt MBkkt removed the WIP Work in progress label Nov 18, 2022
@MBkkt MBkkt self-assigned this Nov 18, 2022
@MBkkt MBkkt merged commit d05a36e into main Nov 18, 2022
@MBkkt MBkkt deleted the lazy-promise branch November 24, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @coveralls