Add WhenAll with output order same as input order #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBkkt
commented
Oct 30, 2022
| using R = std::conditional_t<P == WhenPolicy::None, Result<V, E>, V>; | ||
| auto [future_core, combinator] = detail::AllCombinator<R, E>::Make(count); | ||
| detail::WhenImpl(combinator, begin, count); | ||
| using R = std::conditional_t<F == FailPolicy::None, Result<V, E>, V>; |
There was a problem hiding this comment.
In general no difference between Fifo and Same if R is void.
So I think it always should be Fifo policy, and Same AllCombinator shouldn't work with void
MBkkt
commented
Oct 30, 2022
Comment on lines
+12
to
+14
| void AddInput(BaseCore* core) noexcept { | ||
| core->SetInline(*this); | ||
| } |
There was a problem hiding this comment.
not null => &
ResultCore<V, E>? to avoid cast
always inline?
044a438 to
db7f8b1
Compare
Pull Request Test Coverage Report for Build 3357611113
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 62 63 +1
Lines 1369 1414 +45
===========================================
+ Hits 1369 1413 +44
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7329db7 to
0ada9ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ArangoDB needs it, I can use coroutine but need smaller diff
Related Information
Testing