Skip to content

Few improvements #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2022
Merged

Few improvements #220

merged 1 commit into from
Oct 23, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Oct 23, 2022 •
edited
Loading

  • Make destroy async callback after return value
  • Add restrictions for Result getters

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner October 23, 2022 17:47
@coveralls
Copy link

coveralls commented Oct 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3308312023

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3287477748: 0.0%
Covered Lines: 1369
Relevant Lines: 1369
💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited
Loading

Codecov Report

Merging #220 (afe6541) into main (ab6b6ba) will not change coverage.
The diff coverage is 100.00%.

❗ Current head afe6541 differs from pull request most recent head f9c280a. Consider uploading reports for the commit f9c280a to get more accurate results

@@            Coverage Diff            @@
##              main      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1368      1369    +1     
=========================================
+ Hits          1368      1369    +1
Impacted Files Coverage Δ
include/yaclib/algo/detail/core.hpp 100.00% <100.00%> (ø)
include/yaclib/util/result.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt
* Make destroy async callback after return value
f9c280a 
* Add restrictions for Result getters
* Add tests
@MBkkt MBkkt merged commit a5862ec into main Oct 23, 2022
@MBkkt MBkkt deleted the make_better branch October 23, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @coveralls