Skip to content

Make it better #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

Make it better #217

merged 1 commit into from
Oct 15, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Oct 15, 2022

Purpose

  • Make Future/Task now can works with const or lvalue
  • WhenAll now support WhenPolicy::None
  • Fix missing pragma once in yaclib/async/contract.hpp

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner October 15, 2022 22:34
@MBkkt MBkkt self-assigned this Oct 15, 2022
@coveralls
Copy link

coveralls commented Oct 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3257487177

  • 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3211091320: 0.0%
Covered Lines: 1358
Relevant Lines: 1358
💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 15, 2022 •
edited
Loading

Codecov Report

Merging #217 (ae935f6) into main (f5e3c76) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #217   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1353      1358    +5     
=========================================
+ Hits          1353      1358    +5
Impacted Files Coverage Δ
include/yaclib/async/contract.hpp 100.00% <ø> (ø)
include/yaclib/lazy/make.hpp 100.00% <ø> (ø)
include/yaclib/async/detail/when_all_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/make.hpp 100.00% <100.00%> (ø)
include/yaclib/async/when_all.hpp 100.00% <100.00%> (ø)
include/yaclib/util/result.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt merged commit e9f58a6 into main Oct 15, 2022
@MBkkt MBkkt deleted the fix-test branch October 15, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @coveralls