Skip to content

Fix forward declaration usability and CI #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2022
Merged

Fix forward declaration usability and CI #216

merged 2 commits into from
Oct 8, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Oct 8, 2022

Purpose

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt marked this pull request as ready for review October 8, 2022 16:22
@MBkkt MBkkt requested a review from kononovk as a code owner October 8, 2022 16:22
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #216 (6b31af4) into main (5443674) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1353      1353           
=========================================
  Hits          1353      1353
Impacted Files Coverage Δ
include/yaclib/async/future.hpp 100.00% <ø> (ø)
include/yaclib/async/promise.hpp 100.00% <ø> (ø)
include/yaclib/fwd.hpp 100.00% <ø> (ø)
include/yaclib/lazy/task.hpp 100.00% <ø> (ø)
include/yaclib/util/result.hpp 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt merged commit f5e3c76 into main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MBkkt